Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing new flow for Multi Configuration generators #325

Merged
merged 12 commits into from
Mar 23, 2021

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Mar 15, 2021

Closes: #322

@czoido czoido requested a review from memsharded March 16, 2021 14:29
@puetzk
Copy link
Contributor

puetzk commented Mar 19, 2021

I think it needs to be made clearer that naming the loop variable CMAKE_BUILD_TYPE was important - the fact that's a reserved special cmake-variable name is the only reason it has any effect on conan_cmake_autodetect, which is rather subtle. And using those reserved names as local variables is not usually a good practice, so that's kind of sneaky.

@czoido
Copy link
Contributor Author

czoido commented Mar 22, 2021

I think it needs to be made clearer that naming the loop variable CMAKE_BUILD_TYPE was important - the fact that's a reserved special cmake-variable name is the only reason it has any effect on conan_cmake_autodetect, which is rather subtle. And using those reserved names as local variables is not usually a good practice, so that's kind of sneaky.

Hi @puetzk,
Thanks for the comments, I think you are right, I have introduced some changes to make it more explicit, passing the BUILD_TYPE to conan_cmake_autodetect so that the use of the CMake reserved variable does not lead to confusion.

@czoido czoido merged commit 0140fdb into conan-io:develop Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Macro _conan_detect_build_type doesnt work with Visual Studio IDE
3 participants